On Wed, Sep 9, 2009 at 10:53 AM, Frank Lin <[email protected]> wrote:
> I would argue that is also our code to fix. In Style.java, we
> implicitly change an int to a double. So in the case, 42 was changed
> to 42.0 and we were relied on browser to correct it for us. In the
> case of passing a real double 42.1, the fix will not convert it to
> int, it sill be passing as 42.1.
Your change isn't fixing anything in the scenario you describe.
If the user is calling setPropertyPx, we'll only accept an int, so 42.1
is already coerced to an int. No bug.
If the user happens to call setProperty("border-width", 42.1, Unit.PX),
your new int method won't be called.
http://gwt-code-reviews.appspot.com/66801
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
