[gwt-contrib] issue 3974 Cleanup output from JavaScriptException#getProperties0() now that we have stack traces

[fredsa]

Reviewers: scottb,



Please review this at http://gwt-code-reviews.appspot.com/66803

Affected files:
   user/src/com/google/gwt/core/client/JavaScriptException.java
   user/test/com/google/gwt/core/client/JavaScriptExceptionTest.java


Index: user/src/com/google/gwt/core/client/JavaScriptException.java
===================================================================
--- user/src/com/google/gwt/core/client/JavaScriptException.java        
(revision  
6137)
+++ user/src/com/google/gwt/core/client/JavaScriptException.java        
(working  
copy)
@@ -73,33 +73,7 @@
      return (e == null) ? null : e.name;
    }-*/;

-  private static String getProperties(Object e) {
-    return (e instanceof JavaScriptObject)
-        ? getProperties0((JavaScriptObject) e) : "";
-  }
-
    /**
-   * Returns the list of properties of an unexpected JavaScript exception.
-   */
-  private static native String getProperties0(JavaScriptObject e) /*-{
-    var result = "";
-    try {
-      for (prop in e) {
-        if (prop != "name" && prop != "message" && prop != "toString") {
-          try {
-            result += "\n " + prop + ": " + e[prop];
-          } catch (ignored) {
-            // Skip the property if it threw an exception.
-          }
-        }
-      }
-    } catch (ignored) {
-      // If we can't do "in" on the exception, just return what we have.
-    }
-    return result;
-  }-*/;
-
-  /**
     * The original description of the JavaScript exception this class wraps,
     * initialized as <code>e.message</code>.
     */
@@ -199,7 +173,7 @@
    private void init() {
      name = getName(e);
      description = getDescription(e);
-    message = "(" + name + "): " + description + getProperties(e);
+    message = "(" + name + "): " + description;
    }

  }
Index: user/test/com/google/gwt/core/client/JavaScriptExceptionTest.java
===================================================================
--- user/test/com/google/gwt/core/client/JavaScriptExceptionTest.java    
(revision 6137)
+++ user/test/com/google/gwt/core/client/JavaScriptExceptionTest.java    
(working copy)
@@ -31,9 +31,7 @@
        toString:function() {
          return "jso";
        },
-      name: "myName",
-      message: "myDescription",
-      extraField: "extraData"
+      name: "myName"
      };
    }-*/;

@@ -94,8 +92,6 @@
        assertSame(jso, e.getException());
        assertTrue(e.getMessage().contains("myName"));
        assertTrue(e.getMessage().contains("myDescription"));
-      assertTrue(e.getMessage().contains("extraField"));
-      assertTrue(e.getMessage().contains("extraData"));
      }
    }




--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---