Reviewers: jat, Message: For some reason, Reitveld 404s on JavaObject and HtmlUnitSessionHandler, so comments are here:
HtmlUnitSessionhandler ====================== Can you explain what you are having to do with NativeString? http://gwt-code-reviews.appspot.com/64817/diff/1/2 File dev/oophm/overlay/com/google/gwt/dev/shell/JsValueGlue.java (right): http://gwt-code-reviews.appspot.com/64817/diff/1/2#newcode177 Line 177: */ I think HostedModeException is correct here, as this something that is only happening because of hosted mode. Unless there is a bug in GWT, this should only happen when you call Java code from JSNI with the wrong parameter types. http://gwt-code-reviews.appspot.com/64817/diff/1/5 File dev/oophm/src/com/google/gwt/dev/shell/BrowserChannel.java (right): http://gwt-code-reviews.appspot.com/64817/diff/1/5#newcode77 Line 77: } Why was this moved outside the constructor? http://gwt-code-reviews.appspot.com/64817/diff/1/6 File dev/oophm/src/com/google/gwt/dev/shell/JsValueOOPHM.java (right): http://gwt-code-reviews.appspot.com/64817/diff/1/6#newcode147 Line 147: JsObjectRef.checkIdMap(jsRefId); I'm not sure I understand what is going on with this change and the corresponding one in BrowserChannel. http://gwt-code-reviews.appspot.com/64817/diff/1/10 File user/src/com/google/gwt/junit/JUnitShell.java (left): http://gwt-code-reviews.appspot.com/64817/diff/1/10#oldcode697 Line 697: } I assume with this removal, SWT no longer works, right? http://gwt-code-reviews.appspot.com/64817/diff/1/10 File user/src/com/google/gwt/junit/JUnitShell.java (right): http://gwt-code-reviews.appspot.com/64817/diff/1/10#newcode430 Line 430: private static final int TEST_BEGIN_TIMEOUT_MILLIS = 6000000; This needs to get lowered. http://gwt-code-reviews.appspot.com/64817/diff/1/10#newcode621 Line 621: setHeadless(GraphicsEnvironment.isHeadless()); Why set this twice? http://gwt-code-reviews.appspot.com/64817/diff/1/10#newcode651 Line 651: consoleLogger.setMaxDetail(TreeLogger.INFO); Why is this needed? Please review this at http://gwt-code-reviews.appspot.com/64817 Affected files: dev/oophm/build.xml dev/oophm/overlay/com/google/gwt/dev/shell/JsValueGlue.java dev/oophm/src/com/google/gwt/dev/shell/BrowserChannel.java dev/oophm/src/com/google/gwt/dev/shell/HtmlUnitSessionHandler.java dev/oophm/src/com/google/gwt/dev/shell/JavaObject.java dev/oophm/src/com/google/gwt/dev/shell/JsValueOOPHM.java dev/oophm/src/com/google/gwt/dev/shell/SessionData.java user/build.xml user/src/com/google/gwt/junit/JUnitShell.java user/src/com/google/gwt/junit/RunStyleHtmlUnit.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
