Hi Ray, one nitpick but more importantly, we need to add a test case for this to CompilerSuite, either in an existing class or in a new one, just do whatever seems best.
Now for some speculation that I'm not at all sure about. I suspect there are at least two different ways of getting to this particular code location. One of them is from processSuperConstructorCall(ExplicitConstructorCall x), and another one would be createQualifiedThisRef(SourceInfo info, JClassType targetType). Ideally, the test would cover at least these two code paths where a "val$this$" is used. http://gwt-code-reviews.appspot.com/68801/diff/1/2 File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java (right): http://gwt-code-reviews.appspot.com/68801/diff/1/2#newcode1951 Line 1951: // in some circumstances, the outer this ref can be captured as a local Nitpick: use a multi-line comment so the text can autoformat. Capitalize the sentence. http://gwt-code-reviews.appspot.com/68801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
