Reviewers: jgw,

Description:
Description:
==============
If you run tests out of module order (ie, you do not use a
GWTTestSuite), you will get an IllegalArgumentException (Cannot add test
blocks after the last block is added) when a repeat module is compiled.
The bug was recently introduced after my JUnitShell patch.

Fix:
===
We now keep track of which modules have been compiled and only add the
batches of tests the first time a module is compiled.  Note that the
tests will have already run for the module, so we do actually batch the
tests on the client even if the user does not use a GWTTestSuite.

Testing:
========
I added a TestSuite that uses TestSuite instead of GWTTestSuite and
verified that it fails before the fix, but passes with the fix.

Please review this at http://gwt-code-reviews.appspot.com/67803

Affected files:
   user/src/com/google/gwt/junit/CompileStrategy.java
   user/test/com/google/gwt/junit/JUnitTest.gwt.xml
   user/test/com/google/gwt/junit/JUnitTest2.gwt.xml
   user/test/com/google/gwt/junit/TestSuiteTest.java
   user/test/com/google/gwt/junit/client/ModuleOneTest.java
   user/test/com/google/gwt/junit/client/ModuleOneTest2.java
   user/test/com/google/gwt/junit/client/ModuleTwoTest.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to