Reviewers: scottb,

Message:
Review requested.


http://gwt-code-reviews.appspot.com/71802/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (left):

http://gwt-code-reviews.appspot.com/71802/diff/1/2#oldcode451
Line 451: jsoSubType.clearImplements();
This removal is necessary to ensure the correct computation of virtual
overrides in JTypeOracle.

Description:
The SingleJsoImpl implementation did not allow for virtual overrides of
the interface methods.  Given the following case:

class A extends JSO {
   int method() {}
}
interface I {
   int method();
}
class B extends A implements I {}

dispatches to I.method() would not get rewritten to A.method().
Instead, the compiler and hosted mode would attempt to use a
non-existent B.method().

Please review this at http://gwt-code-reviews.appspot.com/71802

Affected files:
   M dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java
   M dev/core/src/com/google/gwt/dev/jjs/impl/JavaScriptObjectNormalizer.java
   M dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
   M user/test/com/google/gwt/dev/jjs/test/singlejso/TypeHierarchyTest.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to