Also, is there a reason we can't discard junit.headless from common.ant.xml,
rather than hardcoding it true?

On Thu, Sep 24, 2009 at 3:53 PM, <[email protected]> wrote:

> LGTM
>
> Reitveld is again acting up -- I couldn't actually view any of the files
> but the first and last, but I could get a diff of the whole patch to
> look at.
>
>
> http://gwt-code-reviews.appspot.com/71804/diff/1/2
> File common.ant.xml (right):
>
> http://gwt-code-reviews.appspot.com/71804/diff/1/2#newcode185
> Line 185: <jvmarg line="-Xmx2048m" />
> I don't know that we want to increase this in the build file.
>
> http://gwt-code-reviews.appspot.com/71804/diff/1/7
> File user/build.xml (right):
>
> http://gwt-code-reviews.appspot.com/71804/diff/1/7#newcode145
> Line 145: <gwt.junit test.args="${test.args}"
> test.out="${junit.out}/${build.host.platform}-hosted-mode"
> test.cases="test.hosted.tests" >
> I assume this is temporary?
>
>
> http://gwt-code-reviews.appspot.com/71804
>

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to