There are two versions of Benchmark, a JVM version that does reference Strategy, and a super-src version for GWT use that doesn't. A user would similarly have to split their testcase if they actually wanted to override the strategy, because that interface isn't available to client code.
On Fri, Sep 25, 2009 at 1:37 PM, John LaBanca <[email protected]> wrote: > It isn't client code, but it is part of the user code. Couldn't somebody > override getStrategy() to return a new strategy, the same way we did with > Benchmark? > > Thanks, > John LaBanca > [email protected] > > > On Fri, Sep 25, 2009 at 1:01 PM, Scott Blum <[email protected]> wrote: > >> John, I'm kind of puzzled... how would a user actually override >> getStrategy()? The Strategy type is not compilable GWT client code, so a >> GWTTestCase that actually does the override should fail to compile as GWT >> client code. What am I missing? >> >> >> On Fri, Sep 25, 2009 at 11:33 AM, John LaBanca <[email protected]>wrote: >> >>> If you override JUnitShell.Strategy, you should consider this email. >>> >>> >>> JUnitShell.Strategy, which determines how GWT modules are compiled for >>> test cases, is currently an interface. We would like to change it to be a >>> class so we can add methods without breaking code. This is a relatively >>> obscure class, so it should have, limited effect. See the Benchmark class >>> for an example of its use. >>> >>> What prompted this change is a patch that pmuetschard created which >>> allows users to annotate individual test methods with @WithModuleParameters, >>> controlling the deferred bindings for that specific test. The patch adds a >>> method to the existing JUnitShell.Strategy interface. >>> http://gwt-code-reviews.appspot.com/71801/show >>> >>> Thanks, >>> John LaBanca >>> [email protected] >>> >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
