LGTM.
On Mon, Sep 28, 2009 at 9:09 AM, Freeland Abbott <[email protected]> wrote:
> Amit, one part of the same fix from farewellSwt that I think we want in
> trunk "early". It shouldn't cause upmerge issues, and seems important:
> Index: common.ant.xml
> ===================================================================
> --- common.ant.xml (revision 6233)
> +++ common.ant.xml (working copy)
> @@ -199,7 +199,6 @@
> <isset property="emma.enabled" />
> </condition>
>
> - <echo message="${javac.out} ${javac.junit.out}" />
> <junit dir="@{test.out}" fork="yes" printsummary="yes"
> failureproperty="junit.failure" tempdir="@{test.out}">
> <jvmarg line="${junit.platform.args}" />
> @@ -249,7 +248,7 @@
> <condition property="junit.stop.build" value="true">
> <and>
> <istrue value="@{haltonfailure}"/>
> - <isset property="${junit.failure}"/>
> + <isset property="junit.failure"/>
> </and>
> </condition>
> <fail message="One or more junit tests failed" if="junit.stop.build"
> />
>
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
