Reviewers: kathrin, Message: Thanks, Kathrin!
I'll rename everything to "compile report". The command-line option would also be good to update, but I don't have any ideas about what to change it to at the moment. Some quick responses are below. I'll go through your review more carefully as soon as I have a little more time. http://gwt-code-reviews.appspot.com/69801/diff/1001/2036 File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java (right): http://gwt-code-reviews.appspot.com/69801/diff/1001/2036#newcode973 Line 973: if (sizeBreakdowns != null) { On 2009/09/28 17:22:00, kathrin wrote: > This seems to be conditioned on whether we use SOYLite. Is this really what we > want? No, the goal was that if you specify detailed stories, you'll get all of: detailed stories, lite stories, and the dashboard output. I'll check whether that is true. http://gwt-code-reviews.appspot.com/69801/diff/1001/2036#newcode996 Line 996: } We should certainly make it as simple as possible! The version here allows doing most of the work on a permutation-by-permutation basis. The command-line version would have to be run in Link and so would not be shardable across multiple build machines. So the command-line version can't be reused without giving up the ability to shard the SOYC report generation. We could collapse all these calls down it if looks like it would help, though. Right now it's read, read, read, generate. It could be just read (with three arguments) followed by generate. Or even just a single generate call that does reading and writing. Do either of those alternatives sound better? http://gwt-code-reviews.appspot.com/69801/diff/1001/2028 File dev/core/src/com/google/gwt/soyc/GlobalInformation.java (right): http://gwt-code-reviews.appspot.com/69801/diff/1001/2028#newcode42 Line 42: private final String permutationId; Sounds good to me. "PermutationBreakdown"? Other ideas? http://gwt-code-reviews.appspot.com/69801/diff/1001/2032 File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java (right): http://gwt-code-reviews.appspot.com/69801/diff/1001/2032#newcode755 Line 755: // here No, this patch loses that information. We need to think about this part. Since it's only one line of output, I would vote for dropping it for now. I certainly see the argument, though, for not having a regression anywhere. We could figure out a way. It just takes some more work. Description: This patch has the compiler run the SOYC dashboard if -soyc is specified. The output goes into a directory named "compile-report" along with the rest of the compiled app. The dashboard can still be run via the SoycDashboard main class, but presumably we'll deprecate that, unless there's some real use in running it separately. Details on the implementation: The patch doesn't show it properly, but the CSS and PNG files are all moved from tools/soyc directory to their place in the package hierarchy under dev/core/src . As a result, the ant build files are simplified. There is an OutputDirectory abstraction for where the dashboard output goes. When run from the command line, it goes directly to files. When run via -soyc, it goes into artifacts, which then go through the linker system and eventually into files. The Settings class is much less pervasive. It's only available on code paths that definitely involve running SoycDashboard.main. SoycDashboard is now instantiable. It's passed an output directory as one of its arguments. To get its information, SoycDashboard has some public methods indicating where to read size, etc., information from. SoycDashboard has two separate generate() methods now. One of generates the HTML for one permutation, and the other generates the files that aren't tied to any one permutation. I haven't carefully checked, but the output files are supposed to be the same, with just one small change described below. All of the diffs that look like a cut and paste really are. The one small change in the output is that the page for an individual permutation doesn't show the permutation info for that permutation. We should talk about how to do that with the new factoring. It's a little tricky because, while permutation info is available in the final step of generating permutation-agnostic output, it's not available--at least not from the same source--at the point where per-permutation files are now generated. Please review this at http://gwt-code-reviews.appspot.com/69801 Affected files: dev/common.ant.xml dev/core/src/com/google/gwt/core/ext/linker/CompilationAnalysis.java dev/core/src/com/google/gwt/core/ext/linker/impl/StandardCompilationAnalysis.java dev/core/src/com/google/gwt/core/linker/SoycReportLinker.java dev/core/src/com/google/gwt/core/linker/SymbolMapsLinker.java dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java dev/core/src/com/google/gwt/soyc/GlobalInformation.java dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java dev/core/src/com/google/gwt/soyc/Settings.java dev/core/src/com/google/gwt/soyc/SoycDashboard.java dev/core/src/com/google/gwt/soyc/StaticResources.java dev/core/src/com/google/gwt/soyc/io/ArtifactsOutputDirectory.java dev/core/src/com/google/gwt/soyc/io/FileSystemOutputDirectory.java dev/core/src/com/google/gwt/soyc/io/OutputDirectory.java dev/core/src/com/google/gwt/soyc/resources/classLevel.css dev/core/src/com/google/gwt/soyc/resources/common.css dev/core/src/com/google/gwt/soyc/resources/roundedCorners.css tools/soyc-vis/build.xml tools/soyc-vis/classLevel.css tools/soyc-vis/common.css tools/soyc-vis/images/1bl.gif tools/soyc-vis/images/1br.gif tools/soyc-vis/images/1tl.gif tools/soyc-vis/images/1tr.gif tools/soyc-vis/images/bb.gif tools/soyc-vis/images/blc.gif tools/soyc-vis/images/brc.gif tools/soyc-vis/images/l.gif tools/soyc-vis/images/r.gif tools/soyc-vis/images/roundedbox_lo.gif tools/soyc-vis/images/roundedbox_lu.gif tools/soyc-vis/images/roundedbox_ro.gif tools/soyc-vis/images/roundedbox_ru.gif tools/soyc-vis/images/tb.gif tools/soyc-vis/images/tlc.gif tools/soyc-vis/images/trc.gif tools/soyc-vis/roundedCorners.css --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
