Reviewers: fabbott,

Description:
Description:
============
If a test runner shards test methods (runs them on separate threads for
performance), clients will run all test methods in a module for each
shard instead of executing only the test methods that were actually
added. The problem is that we send the test blocks to the client at
compile time, before we know if the test method will actually execute.

Fix:
===
If the user specifies no batching and no precompile (the default in both
cases), we send tests blocks to the client as they execute in JUnit.
Even though the tests are compiled, they will not be executed on the
client.

If the user specifies a batching strategy or a precompile strategy, we
still send the batches at compile time because we cannot wait until run
time to know if a test actually needs to be run.

Testing:
=======
Verified that the tests pass with various combinations of strategies,
and stepped through the code to verify the code path.

Please review this at http://gwt-code-reviews.appspot.com/74803

Affected files:
   user/src/com/google/gwt/junit/BatchingStrategy.java
   user/src/com/google/gwt/junit/CompileStrategy.java
   user/src/com/google/gwt/junit/JUnitShell.java
   user/test/com/google/gwt/junit/BatchingStrategyTest.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to