Does there exist a CompileStrategyTest? (hint.)
http://gwt-code-reviews.appspot.com/74803/diff/1/3 File user/src/com/google/gwt/junit/BatchingStrategy.java (right): http://gwt-code-reviews.appspot.com/74803/diff/1/3#newcode36 Line 36: private boolean isSingleTestOnly; is this pattern better than having BatchingStrategy specify an abstract boolean isSingleTestOnly(), and having constant-returning implementations from the concrete classes? (Very minor storage-space benefits to the second, as well as the ability to have deeper hierarchies with varying values...) http://gwt-code-reviews.appspot.com/74803/diff/1/4 File user/src/com/google/gwt/junit/CompileStrategy.java (right): http://gwt-code-reviews.appspot.com/74803/diff/1/4#newcode50 Line 50: * Strategies that do not add test blocks during compilation should override "do" vice "do not"? (This impl is no-op, so why would I need to override it if I don't add test blocks...) http://gwt-code-reviews.appspot.com/74803/diff/1/4#newcode100 Line 100: boolean addTestBlocks) throws UnableToCompleteException { would it be cleaner (more symmetric) to pass the whole BatchingStrategy, not just the boolean, as you do in maybeAddTestBlockForCurrentTest(...)? Although, I see your other strategies don't reference BatchingStrategy; does it make sense to use different combinations with them? (If I'm sharding, I can be that probably I'll get some methods from each module in each shard, so maybe I'd want to precompile everything, for example, but not batch due to sharding...) http://gwt-code-reviews.appspot.com/74803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
