LGTM. Can you add a TODO to remove the annotation when we update to HtmlUnit-2.7 or above?
On Fri, Oct 2, 2009 at 10:40 AM, <[email protected]> wrote: > Reviewers: amitmanjhi, > > Description: > Description: > After r6263 (run HtmlUnit FF3 using gecko1_8 instead of gecko), an > HtmlUnit bug was uncovered where it does not clear out all elements when > setInnerText() is called. > > Supposedly this is a known issue that was fixed in the branch. This > patch fixes it in trunk. > > Fix: > Adding @DoNotRunWith(Platform.Htmlunit) to both tests. > > Please review this at http://gwt-code-reviews.appspot.com/75803 > > Affected files: > user/test/com/google/gwt/dom/client/ElementTest.java > user/test/com/google/gwt/user/client/ui/DOMTest.java > > > Index: user/test/com/google/gwt/dom/client/ElementTest.java > =================================================================== > --- user/test/com/google/gwt/dom/client/ElementTest.java (revision > 6284) > +++ user/test/com/google/gwt/dom/client/ElementTest.java (working > copy) > @@ -524,6 +524,7 @@ > /** > * innerText. > */ > + @DoNotRunWith(Platform.Htmlunit) > public void testSetInnerText() { > Document doc = Document.get(); > > Index: user/test/com/google/gwt/user/client/ui/DOMTest.java > =================================================================== > --- user/test/com/google/gwt/user/client/ui/DOMTest.java (revision > 6284) > +++ user/test/com/google/gwt/user/client/ui/DOMTest.java (working > copy) > @@ -293,6 +293,7 @@ > * Tests that {...@link DOM#setInnerText(Element, String)} works > consistently > * across browsers. > */ > + @DoNotRunWith(Platform.Htmlunit) > public void testSetInnerText() { > Element tableElem = DOM.createTable(); > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
