Actually, I'd have to create a separate package. Is it worth it to add c.g.g.url? c.g.g.http seems like the natural place for UrlBuilder.
Thanks, John LaBanca [email protected] On Mon, Oct 5, 2009 at 1:27 PM, John LaBanca <[email protected]> wrote: > I was going to put it in com.google.gwt.http.client, but unfortunately, > HTTP.gwt.xml inherits c.g.g.user.User. I can add URL.gwt.xml that does not > inherit User. > > Thanks, > John LaBanca > [email protected] > > > On Mon, Oct 5, 2009 at 1:23 PM, Joel Webber <[email protected]> wrote: > >> Cool. Just don't put it in c.g.g.user.client, please. Don't care much >> where it goes, as long as it's somewhere that doesn't require you to inherit >> User. >> >> >> On Mon, Oct 5, 2009 at 1:12 PM, John LaBanca <[email protected]> wrote: >> >>> We are going to create a separate UrlBuilder class. See the latest patch >>> set. >>> >>> Thanks, >>> John LaBanca >>> [email protected] >>> >>> >>> On Mon, Oct 5, 2009 at 1:11 PM, Ray Cromwell <[email protected]>wrote: >>> >>>> >>>> My only comment is, why put this on the Window class? URL >>>> building/parsing is useful for lots of things. Seems like it should be its >>>> own standalone class. >>>> -Ray >>>> >>>> >>>> On Fri, Oct 2, 2009 at 8:13 AM, <[email protected]> wrote: >>>> >>>>> >>>>> Reviewers: jlabanca, >>>>> >>>>> Description: >>>>> I propose adding a new class Window.LocationBuilder that makes it easy >>>>> to create or modify URLs. We've run into a couple of issues where we >>>>> want to modify a single query parameter and found that a class like >>>>> this >>>>> would be useful. Feedback would be appreciated. >>>>> >>>>> Users can create an empty builder or generate one based on the current >>>>> page using the following methods. See the Showcase sample in the >>>>> attached patch set for an example. >>>>> // Empty builder >>>>> Window.LocationBuilder.create() >>>>> >>>>> // Predefined with values from current page >>>>> Window.Location.createBuilder() >>>>> >>>>> LocationBuilder supports the following APIs to build the URL. Most >>>>> methods are fairly robust. For example, the host can be "google.com" >>>>> or >>>>> "google.com:80". >>>>> build() >>>>> get/setHash(String) >>>>> get/setHost(String) >>>>> get/setPath(String) >>>>> get/setPort(int) >>>>> get/setProtocol(String) >>>>> >>>>> Parameters are set using the following API: >>>>> get/setParameter(String, String) >>>>> get/setParameter(String, List<String>) >>>>> remoteParameter(String) >>>>> >>>>> Please review this at http://gwt-code-reviews.appspot.com/75802 >>>>> >>>>> Affected files: >>>>> >>>>> samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java >>>>> user/src/com/google/gwt/user/client/Window.java >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>> >>> >>> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
