I can review today. The redundant code is in com.google.gwt.uibinder.rebind.CssResourceWriter.
Perhaps I'm wrong to be dismissive of Keith's concerns--we're aiming at different audiences. He's' generating source that people will work with directly, I'm generating source that will only be accessed via attribute settings in a ui.xml file. @Keith, what do you do when you see save_button--do you convert it and provide an annotation to point back to the .css name? If we do wind up with shared code (not convinced we should in light of the above), perhaps it needs two styles. For that matter, given the existence of ui:style, is the need for this utility still clear? Not saying it isn't, just unclear on its expected use. rjrjr On Wed, Oct 7, 2009 at 6:23 AM, BobV <[email protected]> wrote: > On Wed, Oct 7, 2009 at 12:22 AM, <[email protected]> wrote: > > Bob, is this going in? When it does, should I retool UiBinder to use it > > for <ui:style>? > > It didn't occur to me until now that you would have to have code like > this in UiBinder to generate the synthetic interfaces. Would it be > easier to extract that into this tool? If not, what's the relevant > class in the UiBinder code to update so that there's only one > css-to-interface creator? > > Either way, do you have time to review the two patches? > > -- > Bob Vawter > Google Web Toolkit Team > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
