LGTM. You could add an automatic test to at least verify that the DataResource returns something for getUrl().
http://gwt-code-reviews.appspot.com/77808/diff/1/2 File user/src/com/google/gwt/uibinder/rebind/BundleWriter.java (right): http://gwt-code-reviews.appspot.com/77808/diff/1/2#newcode63 Line 63: strictAnnotationType = oracle.findType(Strict.class.getCanonicalName()); Diff/merge problems? http://gwt-code-reviews.appspot.com/77808/diff/1/3 File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java (right): http://gwt-code-reviews.appspot.com/77808/diff/1/3#newcode55 Line 55: private final JClassType dataResourceType; Sort order http://gwt-code-reviews.appspot.com/77808/diff/1/3#newcode134 Line 134: // @source is optional on ImageResource Swap comment and assignment http://gwt-code-reviews.appspot.com/77808/diff/1/4 File user/src/com/google/gwt/uibinder/rebind/model/ImplicitClientBundle.java (right): http://gwt-code-reviews.appspot.com/77808/diff/1/4#newcode116 Line 116: * Called to declare a new ImageResource accessor on this bundle. Copy-and-paste. http://gwt-code-reviews.appspot.com/77808/diff/1/4#newcode123 Line 123: public ImplicitDataResource createDataResource(String name, String source) { Sort order. Did you run checkstyle? http://gwt-code-reviews.appspot.com/77808/diff/1/6 File user/src/com/google/gwt/uibinder/rebind/model/ImplicitDataResource.java (right): http://gwt-code-reviews.appspot.com/77808/diff/1/6#newcode19 Line 19: * Models a method returning an DataResource on a generated ClientBundle. s/an/a/ http://gwt-code-reviews.appspot.com/77808 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
