FWIW, I used the old DOM methods so as not to conflate updating the class with this patch. We'll come back and do a mass-update to the newer DOM methods in a separate pass.
On 2009/10/12 21:04:54, jlabanca wrote: > LGTM > http://gwt-code-reviews.appspot.com/78810/diff/1/2 > File user/src/com/google/gwt/user/client/ui/ScrollPanel.java (right): > http://gwt-code-reviews.appspot.com/78810/diff/1/2#newcode44 > Line 44: DOM.setStyleAttribute(containerElem, "position", "relative"); > Might be better to use containerElem.getStyle().setPosition(Position.Relative) > http://gwt-code-reviews.appspot.com/78810/diff/1/2#newcode49 > Line 49: DOM.setStyleAttribute(containerElem, "zoom", "1"); > You could use getStyle() here too http://gwt-code-reviews.appspot.com/78810 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
