Reviewers: jlabanca, Description: Hi John,
could you review this patch for me? It's very small. The problem we were seeing was that for tree items, right- and middle-clicks were handled and the associated event were fired. This patch checks that only left-clicks fire such events. Thanks! kathrin Please review this at http://gwt-code-reviews.appspot.com/78813 Affected files: user/src/com/google/gwt/user/client/ui/Tree.java Index: user/src/com/google/gwt/user/client/ui/Tree.java =================================================================== --- user/src/com/google/gwt/user/client/ui/Tree.java (revision 6346) +++ user/src/com/google/gwt/user/client/ui/Tree.java (working copy) @@ -541,7 +541,9 @@ // Currently, the way we're using image bundles causes extraneous events // to be sunk on individual items' open/close images. This leads to an // extra event reaching the Tree, which we will ignore here. - if (DOM.eventGetCurrentTarget(event) == getElement()) { + // Also, ignore middle and right clicks here. + if ((DOM.eventGetCurrentTarget(event) == getElement()) + && (event.getButton() == Event.BUTTON_LEFT)) { elementClicked(DOM.eventGetTarget(event)); } break; --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
