LGTM, with a couple comments to consider. Also, if more classes are ever put into the dev.ui package, we may want to move all of the callback classes to dev.ui.events
http://gwt-code-reviews.appspot.com/77818/diff/1/24 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/77818/diff/1/24#newcode630 Line 630: * Callback for the UI to indicate it is down. down --> done, or exited. http://gwt-code-reviews.appspot.com/77818/diff/1/37 File dev/core/src/com/google/gwt/dev/ui/CloseModuleCallback.java (right): http://gwt-code-reviews.appspot.com/77818/diff/1/37#newcode26 Line 26: * The user has requested the a module should be closed. In the event the The user has requested the-->that a module should be closed. In the event <that> the... http://gwt-code-reviews.appspot.com/77818/diff/1/33 File dev/core/src/com/google/gwt/dev/ui/DevModeUI.java (right): http://gwt-code-reviews.appspot.com/77818/diff/1/33#newcode47 Line 47: private final Map<UiEvent.Type<?>, UiCallback> callbacks = new HashMap< You can use ? instead of UICallback, can't you? http://gwt-code-reviews.appspot.com/77818/diff/1/33#newcode149 Line 149: UiEvent.Type<?> eventType) { Can't you use UIcallback instead of ? here? http://gwt-code-reviews.appspot.com/77818/diff/1/33#newcode177 Line 177: protected final boolean hasCallback(UiEvent.Type<?> eventType) { Can't you use UICallback instead of ? here? http://gwt-code-reviews.appspot.com/77818/diff/1/32 File dev/core/src/com/google/gwt/dev/ui/UiEvent.java (right): http://gwt-code-reviews.appspot.com/77818/diff/1/32#newcode35 Line 35: private static int nextId = 0; Is this completely thread-safe? That is, are all instances of the Type object created by the same thread? http://gwt-code-reviews.appspot.com/77818/diff/1/32#newcode47 Line 47: // Since we require only one instance of each type object to be created, I agree with your invariant, but I could see someone making a mistake. Why not create a static map with names and ids and use that to assign the same id for those objects with the same names at construction time? http://gwt-code-reviews.appspot.com/77818 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
