LGTM, except with one small issue and one nit.  I don't need to rereview
it.



http://gwt-code-reviews.appspot.com/66804/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):

http://gwt-code-reviews.appspot.com/66804/diff/1/3#newcode239
Line 239: } while (didChange);
This outer while loop can be left out, can't it, until a second
optimizer is added?   If Intraprocedural doesn't already loop on each
method, then it would be better if it did.

http://gwt-code-reviews.appspot.com/66804/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/Intraprocedural.java
(right):

http://gwt-code-reviews.appspot.com/66804/diff/1/2#newcode54
Line 54: new DeadCodeElimination(program);
The dce field could be made an instance field of IntraProcedural so that
it doesn't have to be recreated all the time.

http://gwt-code-reviews.appspot.com/66804

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to