Some feedback on the final patch.
http://gwt-code-reviews.appspot.com/81805/diff/2011/3011 File dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java (right): http://gwt-code-reviews.appspot.com/81805/diff/2011/3011#newcode70 Line 70: pendingRequestMap.put(requestId, this); The put should happen before the send. http://gwt-code-reviews.appspot.com/81805/diff/2011/3011#newcode150 Line 150: // TODO: Flag the exception Don't need this comment. http://gwt-code-reviews.appspot.com/81805/diff/2011/3011#newcode210 Line 210: messageProcessingThread = new Thread(new Runnable() { THis thread terminates when the stream is closed. http://gwt-code-reviews.appspot.com/81805/diff/2011/3011#newcode226 Line 226: // Terminated when the outputStream is closed Comment is inaccurate; this thread only terminates if it gets interrupted. http://gwt-code-reviews.appspot.com/81805/diff/2011/3013 File dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java (right): http://gwt-code-reviews.appspot.com/81805/diff/2011/3013#newcode187 Line 187: // If the submission was not rejected, this is where we should hit Submission can never be rejected; we never shut down the executor service. http://gwt-code-reviews.appspot.com/81805/diff/2011/3013#newcode343 Line 343: response.get(10000, TimeUnit.SECONDS); Change this back to 2 seconds. http://gwt-code-reviews.appspot.com/81805 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
