Reviewers: rdayal, Message: Probably not. There is no hard convention around protoc generated output that I know of.
On 2009/10/21 05:06:49, fabbott wrote: > http://gwt-code-reviews.appspot.com/83806/diff/1/2 > File dev/build.xml (right): > http://gwt-code-reviews.appspot.com/83806/diff/1/2#newcode212 > Line 212: <filename > name="com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java" negate="yes" /> > perhaps too late, but should we generalize this to e.g. **/*Proto.java? Description: Committed as r6437. Please review this at http://gwt-code-reviews.appspot.com/83806 Affected files: M dev/build.xml M dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java Index: dev/build.xml diff --git a/dev/build.xml b/dev/build.xml index be0bce9ab2a085395853bce2168ebcd3428259ad..584c6279f0acfb829cd64ffcb5d5b45366280d75 100755 --- a/dev/build.xml +++ b/dev/build.xml @@ -209,6 +209,7 @@ <target name="checkstyle" description="Static analysis of source"> <gwt.checkstyle> <fileset dir="core/src"> + <filename name="com/google/gwt/dev/shell/remoteui/RemoteMessageProto.java" negate="yes" /> <filename name="com/google/gwt/dev/asm/**/*.java" negate="yes" /> <filename name="com/google/gwt/dev/js/rhino/**/*.java" negate="yes" /> <filename name="org/eclipse/**/*.java" negate="yes" /> Index: dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java diff --git a/dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java b/dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java index d17d4fe00572c9cab95a5e7f7707aa8641071e6c..b2442d1355a1654b2542525ed51f48873f182d78 100644 --- a/dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java +++ b/dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceRequestProcessor.java @@ -63,7 +63,6 @@ public class DevModeServiceRequestProcessor implements RequestProcessor { throw new IllegalArgumentException( "Unknown DevModeService Request: The DevModeService cannot handle requests of type " + request.getDevModeRequest().getRequestType().name()); - } private Response processCapabilityExchange(int requestId) { --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
