Reviewers: Ray Ryan, Description: Description: ============ Both of these tests use a DeferredCommand and do similar things. They fail in HtmlUnit fairly often on our build system, even with long timeouts.
Fix: ==== Disable the tests on HtmlUnit. Please review this at http://gwt-code-reviews.appspot.com/87804 Affected files: user/test/com/google/gwt/user/client/ui/ListBoxTest.java user/test/com/google/gwt/user/client/ui/StackPanelTest.java Index: user/test/com/google/gwt/user/client/ui/ListBoxTest.java =================================================================== --- user/test/com/google/gwt/user/client/ui/ListBoxTest.java (revision 6452) +++ user/test/com/google/gwt/user/client/ui/ListBoxTest.java (working copy) @@ -15,6 +15,8 @@ */ package com.google.gwt.user.client.ui; +import com.google.gwt.junit.DoNotRunWith; +import com.google.gwt.junit.Platform; import com.google.gwt.junit.client.GWTTestCase; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.DeferredCommand; @@ -38,6 +40,7 @@ assertEquals(0, lb.getItemCount()); } + @DoNotRunWith(Platform.Htmlunit) public void testDebugId() { ListBox list = new ListBox(); list.addItem("option0", "value0"); @@ -49,7 +52,7 @@ list.ensureDebugId("myList"); UIObjectTest.assertDebugId("myList", list.getElement()); - delayTestFinish(250); + delayTestFinish(5000); DeferredCommand.addCommand(new Command() { public void execute() { UIObjectTest.assertDebugIdContents("myList-item0", "option0"); Index: user/test/com/google/gwt/user/client/ui/StackPanelTest.java =================================================================== --- user/test/com/google/gwt/user/client/ui/StackPanelTest.java (revision 6452) +++ user/test/com/google/gwt/user/client/ui/StackPanelTest.java (working copy) @@ -15,6 +15,8 @@ */ package com.google.gwt.user.client.ui; +import com.google.gwt.junit.DoNotRunWith; +import com.google.gwt.junit.Platform; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.DeferredCommand; @@ -54,6 +56,7 @@ HasWidgetsTester.testAll(createStackPanel(), new Adder(), true); } + @DoNotRunWith(Platform.Htmlunit) public void testDebugId() { final StackPanel p = createStackPanel(); Label a = new Label("a"); --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
