RunStyleRemoteWeb#launchModule will detect if the test cannot start, and #doKeepAlives will detect communication errors. If BrowserManager is stuck running a test, then presumably the JUnitShell that opened it will timeout the test after 20 minutes and kill the test, so I think we're covered all around (can't start, communication fails, hang on server).
Thanks, John LaBanca [email protected] On Fri, Oct 23, 2009 at 5:09 PM, John Tamplin <[email protected]> wrote: > On Fri, Oct 23, 2009 at 1:38 PM, <[email protected]> wrote: > >> RunStyleRemoteWeb now takes a similar path as RunStyleManual, giving >> clients unlimited time to start the test. RunStyleRemoteWeb already >> handles communication errors with JUnitShell, so we just check for >> wasInterrupted. >> > > My concern is that it will hang indefinitely if the remote browser is > really hosed -- I am ok with waiting longer for the initial connection, but > I think it needs to still have a timeout. > > Longer term, I think we need t do away with RemoteBrowserManager and > replace it with Selenium. Current versions of Selenium-RC can launch Chrome > and IE, so it seems better to use something that is actually supported and > avoids the known problems with RemoteBrowserManager. > > -- > John A. Tamplin > Software Engineer (GWT), Google > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
