http://gwt-code-reviews.appspot.com/86801/diff/1/11 File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java (left):
http://gwt-code-reviews.appspot.com/86801/diff/1/11#oldcode558 Line 558: + intfMethod.toString(); On 2009/10/24 01:08:05, Ray Ryan wrote: > Why is it okay to delete this? implementingMethod cannot be null because the loop is: while (implementingMethod == null) { // stuff } implementingType cannot be null because if it were null the loop test would have thrown an NPE on implementingType.findMethod http://gwt-code-reviews.appspot.com/86801/diff/1/26 File user/src/com/google/gwt/core/client/GWT.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/26#newcode212 Line 212: @SuppressWarnings("unused") // name parameter will be used following replacement On 2009/10/24 01:08:05, Ray Ryan wrote: > line too long (sorry) do we not use 100 columns? http://gwt-code-reviews.appspot.com/86801/diff/1/33 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/33#newcode72 Line 72: // FIXME - is the (Object) cast actually necessary? On 2009/10/24 01:08:05, Ray Ryan wrote: > Isn't this a clue that toReturn is declared wrong? Shouldn't it be Map<String, ? > extends Object> to allow the cast to go away?I tried this and it doesn't seem to work. I'm just going to eliminate the cast and see what happens. http://gwt-code-reviews.appspot.com/86801/diff/1/29 File user/src/com/google/gwt/uibinder/sample/client/HandlerDemo.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/29#newcode69 Line 69: @SuppressWarnings("unused") On 2009/10/24 01:08:05, Ray Ryan wrote: > What a shame. I wonder if there is anyway we can make @UiHandler itself imply > this? > Surprised to see this needed on a non-private method. And why only this one? The issue is that 'event' is never used -- just the existence of the event matters, not its contents. http://gwt-code-reviews.appspot.com/86801/diff/1/64 File user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/64#newcode148 Line 148: public void updateRightWidth(Element rightElem, int newRightWidth) { On 2009/10/24 01:08:05, Ray Ryan wrote: > Could mention that its an override point for subclasses. Then it should really have some javadoc, no? http://gwt-code-reviews.appspot.com/86801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
