Revision: 6486
Author: rj...@google.com
Date: Tue Oct 27 15:13:22 2009
Log: Trivial fix for issue 4067, UiBinderGenerator is not stable. Miguel
would have fixed this earlier, but thought that the values from domId
were being used directly as, well, DOM ids. Actually they name Java
fields which will hold dom ids at runtime, generated by calls to
com.google.gwt.dom.client.Document.get().createUniqueId().

Manually tested stability via diff of generated code

Reviewed by mmendez
http://code.google.com/p/google-web-toolkit/source/detail?r=6486

Modified:
  /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java

=======================================
--- /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java  Tue  
Oct 27 00:48:50 2009
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java  Tue  
Oct 27 15:13:22 2009
@@ -73,8 +73,6 @@
    private static final String BUNDLE_URI_SCHEME = "urn:with:";
    private static final String PACKAGE_URI_SCHEME = "urn:import:";

-  private static int domId = 0;
-
    // TODO(rjrjr) Another place that we need a general anonymous field
    // mechanism
    private static final String CLIENT_BUNDLE_FIELD  
= "clientBundleFieldNameUnlikelyToCollideWithUserSpecifiedFieldOkay";
@@ -238,6 +236,8 @@

    private final ImplicitClientBundle bundleClass;

+  private int domId = 0;
+
    private int fieldIndex;

    private String gwtPrefix;

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to