http://gwt-code-reviews.appspot.com/86809/diff/1/2
File build.xml (right):

http://gwt-code-reviews.appspot.com/86809/diff/1/2#newcode119
Line 119: <echo message="  or -Dgwt.selenium.hosts, but that's all."/>
On 2009/10/28 03:00:56, zundel wrote:
> I know this is just temporary, but its too bad the top level test
target doesn't
> actually fail if no tests run.  Its hard to believe a human being
would invoke
> the test target and be satisfied with an OK result when nothing
actually ran.
> Frankly, I hardly look at the ant output unless the build fails.

> Testing each of the properties named in the echo message with a
<condition> is
> burdensome, I know, but maybe worth it because this is such a
deviation from
> what we're used to.

It seems bad to always print this message even if the user supplied the
hosts for RBM/Selenium.

Also, ant test will run dev and noserver without any set, so it isn't
that no tests ran.

http://gwt-code-reviews.appspot.com/86809

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to