Reviewers: Lex,

Description:
Hi Lex, in the course of reviewing precompile sharding, I ran across
some improvements to DiskCache and UnifiedAST.

- Renamed "writeTo" to "transferToStream" to avoid the confusion that it
actually does the opposite of the other "write" methods, and added its
inverse "transferFromStream".

- Factored out moveToEndPosition() which fixes a bug where atEnd would
*never* be true, forcing an unnecessary seek on every write.

- Updated some call sites to take advantage of transferFromStream(),
which is more efficient than buffering the whole data stream into a byte
buffer.

- Updated UnifiedAST to take advantage of DiskCache and the newer
serialization techniques, which should reduce memory usage.


Please review this at http://gwt-code-reviews.appspot.com/88804

Affected files:
   dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
    
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardGeneratedResource.java
   dev/core/src/com/google/gwt/dev/jjs/UnifiedAst.java
   dev/core/src/com/google/gwt/dev/util/DiskCache.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to