LGTM

http://gwt-code-reviews.appspot.com/78821/diff/2006/1009
File user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java
(right):

http://gwt-code-reviews.appspot.com/78821/diff/2006/1009#newcode33
Line 33: writer.warn(
This pattern keeps reappearing.  Would it make sense to move this to a
UiBindnerWriter.warnDeprecatedTag() to ensure that future deprecations
follow the same formatting?

http://gwt-code-reviews.appspot.com/78821/diff/2006/1010
File user/src/com/google/gwt/uibinder/sample/client/WidgetBasedUi.ui.xml
(right):

http://gwt-code-reviews.appspot.com/78821/diff/2006/1010#newcode283
Line 283: <p> ... a StackPanel ... </p>
The indentation of the rest of the HorizontalPanel's contents is off.

http://gwt-code-reviews.appspot.com/78821

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to