Mostly questions, and generally speaking you should select the
containing comment blocks and autoformat them into shape (don't
necessarily do the whole file as it generates diff cheese).


http://gwt-code-reviews.appspot.com/89801/diff/1/2
File user/src/com/google/gwt/resources/ext/ResourceContext.java (right):

http://gwt-code-reviews.appspot.com/89801/diff/1/2#newcode95
Line 95: * {...@link #deploy} over {...@link
GeneratorContext#tryCreateResource} in
Does this block reformat?

http://gwt-code-reviews.appspot.com/89801/diff/1/7
File user/src/com/google/gwt/user/client/ui/LayoutPanel.java (right):

http://gwt-code-reviews.appspot.com/89801/diff/1/7#newcode23
Line 23: * A panel that lays its children out in arbitrary {...@link
com.google.gwt.layout.client.Layout.Layer layers}
Why's this needed, given the import?  Same below.  Also, if you really
do need it, these comment blocks will need reformat.

http://gwt-code-reviews.appspot.com/89801/diff/1/4
File user/src/com/google/gwt/user/client/ui/PopupPanel.java (right):

http://gwt-code-reviews.appspot.com/89801/diff/1/4#newcode537
Line 537: * @deprecated Use {...@link #onPreviewNativeEvent} instead
Why is this needed?  (And so on)

http://gwt-code-reviews.appspot.com/89801/diff/1/8
File user/src/com/google/gwt/user/client/ui/RootLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/89801/diff/1/8#newcode27
Line 27: * This panel automatically calls {...@link
RequiresResize#onResize()} on itself when
Reformat.

http://gwt-code-reviews.appspot.com/89801/diff/1/3
File
user/src/com/google/gwt/user/server/rpc/AbstractRemoteServiceServlet.java
(right):

http://gwt-code-reviews.appspot.com/89801/diff/1/3#newcode78
Line 78: * escapes the {...@link #doPost} method. The default
implementation
Reformat.

http://gwt-code-reviews.appspot.com/89801/diff/1/3#newcode105
Line 105: * This information is encoded in the {...@value
com.google.gwt.user.client.rpc.RpcRequestBuilder#STRONG_NAME_HEADER}
Why's this needed, it's a static import?  Needs reformat.

http://gwt-code-reviews.appspot.com/89801

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to