On Wed, Oct 28, 2009 at 6:38 PM, Ray Ryan <rj...@google.com> wrote:

> We usually use gwt-code-reviews.appspot.com, but LGTM'd anyway.
>

Oh yeah -- thanks. Duh.


> Testing is on its way out of user/src and into user/testing, review
> pending.
>

'k.


>
> sample isn't really a sample, it's become a test app. It should
> probably move to user/testing as well.
>

If it's a genuine test (as in a test case), then under user/test makes
sense.


> resources is unique to UiBinder as far as I know. It's the master copy
> of the file that we serve out of
> http://google-web-toolkit.googlecode.com/files/xhtml.ent, and has to
> be available to UiBinderGenerator as a resource at code gen time. Any
> suggestion where to put it instead?
>

Maybe in distro-source? That's where the DTD is, and it feels like a sibling
of that maybe. No strong opinion.

http://code.google.com/p/google-web-toolkit/source/browse/#svn/trunk/distro-source/core/src

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to