Some nits.

Also, should we deprecate AbstractImagePrototype?  Is it used for
anything other than ImageBundle?


http://gwt-code-reviews.appspot.com/89807/diff/11/13
File user/src/com/google/gwt/user/client/ui/AbstractImagePrototype.java
(right):

http://gwt-code-reviews.appspot.com/89807/diff/11/13#newcode52
Line 52: public abstract class AbstractImagePrototype {
Should we deprecate this class as well?  Is it used anywhere other than
ImageBundle?

http://gwt-code-reviews.appspot.com/89807/diff/11/14
File user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java
(right):

http://gwt-code-reviews.appspot.com/89807/diff/11/14#newcode38
Line 38: * <h3>CSS Style Rules</h3> <ul class='css'>
<li>.gwt-HorizontalSplitPanel { the
Can you take the "class='css'" out of here and reformat?

http://gwt-code-reviews.appspot.com/89807/diff/11/14#newcode380
Line 380: * @param images ImageBundle containing an image for the
splitter's drag thumb
You need to add the @deprecated javadoc tag as well:
@deprecated as of GWT 2.0, Use {...@link #HorizontalSplitPanel(Resource)}
instaed

http://gwt-code-reviews.appspot.com/89807/diff/11/17
File user/src/com/google/gwt/user/client/ui/MenuBar.java (right):

http://gwt-code-reviews.appspot.com/89807/diff/11/17#newcode182
Line 182: * @param images a bundle that provides images for this menu
Need an @deprecated JavaDoc tag

http://gwt-code-reviews.appspot.com/89807/diff/11/17#newcode205
Line 205: * @param images a bundle that provides images for this menu
Need an @deprecated JavaDoc tag

http://gwt-code-reviews.appspot.com/89807/diff/11/18
File user/src/com/google/gwt/user/client/ui/Tree.java (right):

http://gwt-code-reviews.appspot.com/89807/diff/11/18#newcode460
Line 460: public String getImageBase() {
Maybe we can just remove this if it was already deprecated?  I don't
think it has any real value, and setImageBase is already gone.

http://gwt-code-reviews.appspot.com/89807/diff/11/20
File user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
(right):

http://gwt-code-reviews.appspot.com/89807/diff/11/20#newcode38
Line 38: * <h3>CSS Style Rules</h3> <ul class='css'>
<li>.gwt-VerticalSplitPanel { the
Remove class='css' and reformat

http://gwt-code-reviews.appspot.com/89807/diff/11/20#newcode283
Line 283: * Creates an empty vertical split panel.
Need @deprecated Javadoc tag

http://gwt-code-reviews.appspot.com/89807

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to