Reviewers: hermes_google.com, rdamazio_google.com,
Message:
Review requested. Hermes, if you won't actually be able to get to this
please let me know as quickly as you can. Our deadline is very near.
Description:
Moving AttributeParsers to XMLElement, where they belong.
This is a pretty major refactoring, and it's not done yet. Management of
the AttributeParser and the BundleAttributeParsers is now in dedicated
classes. XMLElement has access to them, and uses them for Boolean
values. All other parsing is still going through old calls through
UiBinderWriter to the new managers.
But this is a complete vertical slice, so I'd like to get it reviewed
and checked in.
Of particular note: there are now many fewer direct dependencies on
UiBinderWriter, and much more DI style injection of logging and other
services. Also, dummy loggers are introduced to eliminate console noise
from unit tests.
Next steps are making ComputedAttributeParser use the new game (and in
the process tidy its fix for currently broken {{ escaping), and making
the new LayoutPanelParsers get their Double values in the new style.
Then on to strings.
Please review this at http://gwt-code-reviews.appspot.com/91801
Affected files:
M user/src/com/google/gwt/junit/JUnitShell.java
M user/src/com/google/gwt/uibinder/parsers/AttributeParser.java
M user/src/com/google/gwt/uibinder/parsers/BeanParser.java
M user/src/com/google/gwt/uibinder/parsers/BooleanAttributeParser.java
M user/src/com/google/gwt/uibinder/parsers/BundleAttributeParser.java
M user/src/com/google/gwt/uibinder/parsers/CellPanelParser.java
M
user/src/com/google/gwt/uibinder/parsers/ComputedAttributeInterpreter.java
M user/src/com/google/gwt/uibinder/parsers/CustomButtonParser.java
M user/src/com/google/gwt/uibinder/parsers/DisclosurePanelParser.java
M user/src/com/google/gwt/uibinder/parsers/DockPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/FieldInterpreter.java
M user/src/com/google/gwt/uibinder/parsers/HTMLPanelParser.java
M
user/src/com/google/gwt/uibinder/parsers/HorizontalAlignmentConstantParser.java
M user/src/com/google/gwt/uibinder/parsers/IntPairParser.java
M user/src/com/google/gwt/uibinder/parsers/IntParser.java
M user/src/com/google/gwt/uibinder/parsers/MenuBarParser.java
M user/src/com/google/gwt/uibinder/parsers/RadioButtonParser.java
M user/src/com/google/gwt/uibinder/parsers/SimpleAttributeParser.java
M user/src/com/google/gwt/uibinder/parsers/StackPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/StrictAttributeParser.java
M user/src/com/google/gwt/uibinder/parsers/StringAttributeParser.java
M user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/UIObjectParser.java
M
user/src/com/google/gwt/uibinder/parsers/VerticalAlignmentConstantParser.java
A user/src/com/google/gwt/uibinder/rebind/AttributeParsers.java
A user/src/com/google/gwt/uibinder/rebind/BundleAttributeParsers.java
M user/src/com/google/gwt/uibinder/rebind/GetEscapedInnerTextVisitor.java
M user/src/com/google/gwt/uibinder/rebind/GetInnerHtmlVisitor.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
M user/src/com/google/gwt/uibinder/rebind/XMLAttribute.java
M user/src/com/google/gwt/uibinder/rebind/XMLElement.java
A user/src/com/google/gwt/uibinder/rebind/XMLElementProvider.java
A user/src/com/google/gwt/uibinder/rebind/XMLElementProviderImpl.java
M user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java
A user/test/com/google/gwt/uibinder/All.java
M user/test/com/google/gwt/uibinder/UiBinderGwtSuite.java
A user/test/com/google/gwt/uibinder/rebind/DummyMortalLogger.java
A user/test/com/google/gwt/uibinder/rebind/DummyTreeLogger.java
M user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java
M user/test/com/google/gwt/uibinder/rebind/model/OwnerClassTest.java
M user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldClassTest.java
M user/test/com/google/gwt/uibinder/rebind/model/OwnerFieldTest.java
M user/test/com/google/gwt/uibinder/test/client/UiBinderTest.java
M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
