I've responded to the feedback, and implemented most of it. Will commit soon.
http://gwt-code-reviews.appspot.com/91801/diff/300/1297 File user/src/com/google/gwt/uibinder/parsers/AttributeParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1297#newcode25 Line 25: public interface AttributeParser { On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > javadoc is useful. Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1298 File user/src/com/google/gwt/uibinder/parsers/BeanParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1298#newcode55 Line 55: new HashMap<String, JType>(); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > fits in the previous line, no? Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1298#newcode127 Line 127: writer.getAttributeParser(attribute, paramType); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > fits in the previous line. Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1298#newcode133 Line 133: requiredValues.put(propertyName, parser.parse(attribute.consumeRawValue(), On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > wider than 80 cols Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1301 File user/src/com/google/gwt/uibinder/parsers/CellPanelParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1301#newcode52 Line 52: String value = halignParser.parse(cellElem.consumeRawAttribute(HALIGN_ATTR), I'd agree, but out of scope for this patch. http://gwt-code-reviews.appspot.com/91801/diff/300/1302 File user/src/com/google/gwt/uibinder/parsers/ComputedAttributeInterpreter.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1302#newcode50 Line 50: String parsedValue = parser.parse(att.consumeRawValue(), writer.getLogger()); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > wider than 80 cols Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1302#newcode66 Line 66: String parsedValue = parser.parse(att.consumeRawValue(), writer.getLogger()); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > wider than 80 cols Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1302#newcode73 Line 73: * review it Now it's a TODO http://gwt-code-reviews.appspot.com/91801/diff/300/1303 File user/src/com/google/gwt/uibinder/parsers/CustomButtonParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1303#newcode71 Line 71: writer.addStatement("%1$s.get%2$s().setHTML(\"%3$s\");", fieldName, faceName, html); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > wider than 80 cols here and below Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1307 File user/src/com/google/gwt/uibinder/parsers/DoubleAttributeParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1307#newcode1 Line 1: package com.google.gwt.uibinder.parsers; On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > missing disclaimer javadoc Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1309 File user/src/com/google/gwt/uibinder/parsers/HTMLPanelParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1309#newcode34 Line 34: UiBinderWriter.escapeTextForJavaStringLiteral(elem.consumeRawAttribute("tag")); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > 80 cols wider Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1322 File user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1322#newcode60 Line 60: HtmlInterpreter interpreter = HtmlInterpreter.newInterpreterForUiObject( Auto-formatter insists on it. http://gwt-code-reviews.appspot.com/91801/diff/300/1325 File user/src/com/google/gwt/uibinder/rebind/AttributeParsers.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1325#newcode55 Line 55: "com.google.gwt.uibinder.parsers.BooleanAttributeParser"); Refactor of existing code, which I think might be trying to avoid direct linkage. Disinclined to mess. http://gwt-code-reviews.appspot.com/91801/diff/300/1325#newcode60 Line 60: addAttributeParser("int", "com.google.gwt.uibinder.parsers.IntAttributeParser"); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > 80 cols wider Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1326 File user/src/com/google/gwt/uibinder/rebind/BundleAttributeParsers.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1326#newcode45 Line 45: private final Map<String, BundleAttributeParser> parsers = new LinkedHashMap<String, BundleAttributeParser>(); Here and below, I just do what the auto formatter tells me. http://gwt-code-reviews.appspot.com/91801/diff/300/1327 File user/src/com/google/gwt/uibinder/rebind/GetEscapedInnerTextVisitor.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1327#newcode36 Line 36: new ChildWalker().accept(elem, new GetEscapedInnerTextVisitor(buffer, interpreter, On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > 80 cols wider Done. http://gwt-code-reviews.appspot.com/91801/diff/300/1335 File user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java (right): http://gwt-code-reviews.appspot.com/91801/diff/300/1335#newcode118 Line 118: MessageWriter.escapeMessageFormat(elem.consumeRawAttribute(attributeName)); On 2009/11/02 17:23:15, hermesfreitasjunior wrote: > 80 cols wider Done. http://gwt-code-reviews.appspot.com/91801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
