On 2009/11/03 01:50:35, jlabanca wrote:
> As I mentioned before, I'm not all tat familiar with generators,
especially
> complex ones like this. Scott can probably give you better feedback
than I.

> http://gwt-code-reviews.appspot.com/89814/diff/1/2
> File

user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
> (right):

> http://gwt-code-reviews.appspot.com/89814/diff/1/2#newcode559
> Line 559: private Map<ResourceGenerator, List<JMethod>>
initAndPrepare(
> Why did you move this method?

LGTM. Amazing what a pain it is to ensure generator stability.

http://gwt-code-reviews.appspot.com/89814

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to