Reviewers: bobv, Message: Clue and review requested.
Description: Makes User inherit UiBinder, to keep people from having to think about turning it on. But before I submit this, an important question: why did (and does) the test app work if it inherits UiBinder directly, without inheriting User? I can't find any circular dependencies. Please review this at http://gwt-code-reviews.appspot.com/89820 Affected files: M user/src/com/google/gwt/user/User.gwt.xml M user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml Index: user/src/com/google/gwt/user/User.gwt.xml diff --git a/user/src/com/google/gwt/user/User.gwt.xml b/user/src/com/google/gwt/user/User.gwt.xml index 15e7dc5170dcee0571b896196ecf753f52f60d03..0c35ed45fea6d7449e57c4875c9476a59503a3c6 100644 --- a/user/src/com/google/gwt/user/User.gwt.xml +++ b/user/src/com/google/gwt/user/User.gwt.xml @@ -23,6 +23,7 @@ <inherits name="com.google.gwt.animation.Animation"/> <inherits name="com.google.gwt.resources.Resources"/> <inherits name="com.google.gwt.layout.Layout"/> + <inherits name="com.google.gwt.uibinder.UiBinder"/> <inherits name="com.google.gwt.user.AsyncProxy"/> <inherits name="com.google.gwt.user.RemoteService"/> <inherits name="com.google.gwt.user.DocumentRoot" /> Index: user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml diff --git a/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml b/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml index 190e301899f0418246f07757af91043e36acc328..75532fbbd92f196e9013fdaa0ee1caf174a1c74a 100644 --- a/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml +++ b/user/test/com/google/gwt/uibinder/test/UiBinderTestApp.gwt.xml @@ -13,7 +13,7 @@ <!-- GWT UiBinder support. --> <module> - <inherits name="com.google.gwt.uibinder.UiBinder" /> + <inherits name="com.google.gwt.user.User" /> <inherits name="com.google.gwt.debug.Debug"/> <entry-point class="com.google.gwt.uibinder.test.client.UiBinderTestApp" /> </module> --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
