Thanks for the review.

http://gwt-code-reviews.appspot.com/93802/diff/1/4
File dev/core/src/com/google/gwt/dev/shell/log/SwingTreeLogger.java
(right):

http://gwt-code-reviews.appspot.com/93802/diff/1/4#newcode332
Line 332: * @param queuedEvent
On 2009/11/04 17:41:08, Ray Ryan wrote:
> name mismatch

Fixed.

http://gwt-code-reviews.appspot.com/93802/diff/1/4#newcode337
Line 337: public void run() {
On 2009/11/04 17:41:08, Ray Ryan wrote:
> Why don't you need the try/catch any more?

SwingWorker.get() throws those exceptions, and we aren't using
SwingWorker any more.  In this case, the queueing happens entirely
within EventQueue, and logEvent doesn't have to be stored or pulled from
a queue.

http://gwt-code-reviews.appspot.com/93802

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to