Agreed -- we're going to do precisely that. I think we'll probably end up sticking isIE6() in the image bundle code for the moment, as Bob has a better general solution in the pipeline (which he calls soft permutations). But yes, the image bundle insanity on IE6 is the more important of the two that we wanted to fix.
On Mon, Nov 9, 2009 at 11:01 AM, stuckagain <[email protected]> wrote: > > I'm not a code reviewer... but just a useful comment: > > You might want to move the isIE6 method somewhere else so that you > could avoid the memory leak on ie7/ie8 when using ImageBundles as > well. > For ie7 and ie8 this workaround to get transparent PNGs working is no > longer needed and it's leaking a lot of memory. Unless you want to > wait for soft permutations (first time that I hear that mentioned). > > See the following: > http://code.google.com/p/google-web-toolkit/issues/detail?id=3573 > http://code.google.com/p/google-web-toolkit/issues/detail?id=3588 > > David > > On Nov 9, 3:22 pm, [email protected] wrote: > > LGTM. Thanks. > > > > http://gwt-code-reviews.appspot.com/97807/diff/3/1002 > > File user/src/com/google/gwt/user/client/ui/impl/PopupImplIE6.java > > (right): > > > > http://gwt-code-reviews.appspot.com/97807/diff/3/1002#newcode71 > > Line 71: private native void do_onHide(Element popup) /*-{ > > I know these are private, but do_onHide()? Can we just make them > > doOnHide()? > > > > http://gwt-code-reviews.appspot.com/97807 > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
