LGTM, with nits.

http://gwt-code-reviews.appspot.com/97806/diff/1001/56
File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right):

http://gwt-code-reviews.appspot.com/97806/diff/1001/56#newcode50
Line 50: @SuppressWarnings("deprecation")
This is a big class.

http://gwt-code-reviews.appspot.com/97806/diff/1001/62
File
user/test/com/google/gwt/uibinder/elementparsers/UiJavaResources.java
(right):

http://gwt-code-reviews.appspot.com/97806/diff/1001/62#newcode30
Line 30: public static final MockJavaResource DIALOG_BOX = new
MockJavaResource(
These fields should be initialized from a factory method that accepts a
class literal.

http://gwt-code-reviews.appspot.com/97806/diff/1001/66
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
(right):

http://gwt-code-reviews.appspot.com/97806/diff/1001/66#newcode261
Line 261: <span style="white-space:nowrap">The pig's in a hurry</span>
Did you mean to make this change?

http://gwt-code-reviews.appspot.com/97806

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to