LGTM other than minor comments below.
ApiContainerTest and ApiCompatibilityTest throw console errors, even
though the tests pass.
Validating newly compiled units
[ERROR] No JavaScript body found for native method 'protected
native int protectedMethod();' in type 'java.lang.Object'
Refreshing module from source
Validating newly compiled units
[ERROR] No JavaScript body found for native method 'protected
native int protectedMethod();' in type 'java.lang.Object'
http://gwt-code-reviews.appspot.com/97810/diff/1/2
File dev/core/src/com/google/gwt/dev/javac/CompilationState.java
(right):
http://gwt-code-reviews.appspot.com/97810/diff/1/2#newcode414
Line 414: assert (!unitMap.containsKey(typeName));
LGTM
http://gwt-code-reviews.appspot.com/97810/diff/1/8
File dev/core/test/com/google/gwt/dev/javac/CompilationStateTest.java
(right):
http://gwt-code-reviews.appspot.com/97810/diff/1/8#newcode112
Line 112:
perhaps replace with
assertSame(State.ERROR, invalidUnit.getState());
http://gwt-code-reviews.appspot.com/97810/diff/1/8#newcode317
Line 317: assertSame(units2.get(typeName), units3.get(typeName));
LGTM++;
http://gwt-code-reviews.appspot.com/97810/diff/1/9
File
dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java
(left):
http://gwt-code-reviews.appspot.com/97810/diff/1/9#oldcode19
Line 19: import com.google.gwt.dev.javac.CompilationUnit.State;
Cannot view the diff here.I looked at the file in eclipse and
everything seems fine.
http://gwt-code-reviews.appspot.com/97810/diff/1/14
File dev/core/test/com/google/gwt/dev/javac/TypeOracleTestingUtils.java
(right):
http://gwt-code-reviews.appspot.com/97810/diff/1/14#newcode66
Line 66: }
instead
return buildTypeOracle(logger, resources,
Collections.<GeneratedUnit>emptySet());
http://gwt-code-reviews.appspot.com/97810/diff/1/21
File
tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java
(right):
http://gwt-code-reviews.appspot.com/97810/diff/1/21#newcode59
Line 59: *
extra space in this line and above.
http://gwt-code-reviews.appspot.com/97810/diff/1/21#newcode67
Line 67: *
extra space
http://gwt-code-reviews.appspot.com/97810/diff/1/21#newcode74
Line 74: *
extra space
http://gwt-code-reviews.appspot.com/97810/diff/1/21#newcode90
Line 90: *
extra space
http://gwt-code-reviews.appspot.com/97810/diff/1/21#newcode331
Line 331: logger.log(TreeLogger.SPAM, fileName
extra space?
http://gwt-code-reviews.appspot.com/97810/diff/1/25
File
tools/api-checker/test/com/google/gwt/tools/apichecker/ApiContainerTest.java
(right):
http://gwt-code-reviews.appspot.com/97810/diff/1/25#newcode115
Line 115: sb.append("\tprotected native int protectedMethod();\n");
This change does not look related.
http://gwt-code-reviews.appspot.com/97810
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
