Looks good, assuming all those tests you added pass :)

http://gwt-code-reviews.appspot.com/102804/diff/1044/113
File user/src/com/google/gwt/uibinder/rebind/FieldReference.java
(right):

http://gwt-code-reviews.appspot.com/102804/diff/1044/113#newcode92
Line 92: // lack of confidence that all cases can be caught.
I'm sure we're missing a case or two here, but it's on the right track.
The worst thing that can happen is that we let a validation slip
through. But at least we have a place to put it now.

http://gwt-code-reviews.appspot.com/102804

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to