Thanks Rajeev! Also included Scott's assertion message improvements. Committed as r6859.
http://gwt-code-reviews.appspot.com/102803/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.appspot.com/102803/diff/1/3#newcode129 Line 129: + e.getLocalizedMessage()); Switched to e.toString() instead. On 2009/11/11 21:51:44, rdayal wrote: > Not part of your patch, but could you put a null guard here? Though it never > happens now, it may be the case that a termination occurs without any exception. http://gwt-code-reviews.appspot.com/102803/diff/1/3#newcode134 Line 134: try { I'm fine to move it, but is there a reason that the location matters? It would be good to add an explanation. On 2009/11/11 21:49:53, rdayal wrote: > Do this before telling the Dev Mode server that its okay to shut down. http://gwt-code-reviews.appspot.com/102803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
