Reviewers: Dan Rice,
Description:
This patch fixes a few problems when dealing with local classes (those
defined inside a method):
- local classes inside a static method do not have a
synthetic constructor arg passing the containing
instance, as there isn't one
- JSORestrictionsChecker fails on local classes because the
constant pool name can be null
- we were doing work dealing with heuristics that would
not matter ultimately as we will toss local classes from
TypeOracle anyway
In addition, I cleaned up some naming, comments, and formatting.
Please review this at http://gwt-code-reviews.appspot.com/102812
Affected files:
/src/gwt-trunk/dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java
dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
dev/core/src/com/google/gwt/dev/javac/asm/CollectClassData.java
dev/core/src/com/google/gwt/dev/javac/asm/CollectMethodData.java
dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTest.java
dev/core/test/com/google/gwt/dev/javac/asm/CollectClassDataTest.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
