On Fri, Nov 13, 2009 at 12:03 PM, <[email protected]> wrote: > Thanks for the review. Reply below. > > > > http://gwt-code-reviews.appspot.com/102815/diff/1002/3 > File hosted.html (right): > > http://gwt-code-reviews.appspot.com/102815/diff/1002/3#newcode35 > Line 35: var iframeDiv = topDoc.createElement("div"); > On 2009/11/13 16:55:51, jat wrote: > >> Why topDoc instead of $doc? Do you really want it stepping outside of >> > this > >> iframe? >> > > This is the incantation that seemed to work most reliably on IE6 to get > rid of the yucky iframe border. I didn't really investigate too much > why or if there could be a better way. Either way, I think it's fine > because the iframe contents do completely cover up everything on the > page (intentionally - I thought hard about the pros/cons). >
Ok, LGTM -- John A. Tamplin Software Engineer (GWT), Google -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
