Reviewers: jgw, Message: Review requested.
Description: XMLHttpRequest.clearOnReadyStateChange() uses the wrong "this" object and doesn't actually clear the handler. http://code.google.com/p/google-web-toolkit/issues/detail?id=4133 Please review this at http://gwt-code-reviews.appspot.com/100813 Affected files: M user/src/com/google/gwt/xhr/client/XMLHttpRequest.java Index: user/src/com/google/gwt/xhr/client/XMLHttpRequest.java diff --git a/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java b/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java index 8d3a6a4d3b624511b7c07f7c1f1f411d91122c5d..7ebb3da90b7934d164d931d75e883d78bcc7033d 100644 --- a/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java +++ b/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java @@ -111,8 +111,9 @@ public class XMLHttpRequest extends JavaScriptObject { * @see http://www.w3.org/TR/XMLHttpRequest/#onreadystatechange */ public final native void clearOnReadyStateChange() /*-{ + var self = this; $wnd.setTimeout(function() { - this.onreadystatechange = function(){}; + self.onreadystatechange = @null::nullMethod(); }, 0); }-*/; -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
