Revision: 6947 Author: [email protected] Date: Mon Nov 16 18:58:49 2009 Log: JUnitShell should never refresh modules; it's not necesary and can lead to race conditions.
Review by: jlabanca (desk) http://code.google.com/p/google-web-toolkit/source/detail?r=6947 Modified: /trunk/user/src/com/google/gwt/junit/CompileStrategy.java /trunk/user/src/com/google/gwt/junit/JUnitShell.java ======================================= --- /trunk/user/src/com/google/gwt/junit/CompileStrategy.java Mon Nov 16 18:58:22 2009 +++ /trunk/user/src/com/google/gwt/junit/CompileStrategy.java Mon Nov 16 18:58:49 2009 @@ -168,7 +168,7 @@ */ ModuleDef moduleDef = ModuleDefLoader.createSyntheticModule(treeLogger, syntheticModuleName, new String[] { - moduleName, strategy.getModuleInherit()}, true); + moduleName, strategy.getModuleInherit()}, false); // Replace any user entry points with our test runner. moduleDef.clearEntryPoints(); ======================================= --- /trunk/user/src/com/google/gwt/junit/JUnitShell.java Mon Nov 16 18:58:40 2009 +++ /trunk/user/src/com/google/gwt/junit/JUnitShell.java Mon Nov 16 18:58:49 2009 @@ -794,6 +794,13 @@ listener.setIgnoreRemoteDeath(true); } } + + @Override + protected ModuleDef loadModule(TreeLogger logger, String moduleName, + boolean refresh) throws UnableToCompleteException { + // Never refresh modules in JUnit. + return super.loadModule(logger, moduleName, false); + } /** * Checks to see if this test run is complete. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
