http://gwt-code-reviews.appspot.com/103806/diff/1010/1012
File
user/src/com/google/gwt/uibinder/attributeparsers/LengthAttributeParser.java
(right):

http://gwt-code-reviews.appspot.com/103806/diff/1010/1012#newcode28
Line 28: public class LengthAttributeParser implements AttributeParser {
Oh, of course.

You actually could make {someDouble}{someUnit} work. And come to think
of it, there is a good bit of redundancy here with other parsers.

You could have a constructor like:

/**
  * @param d double parser
  * @param e unit parser, expected to be primed to parse
  *    Style.Unit
  */
LengthAttributeParser(DoubleAttributeParser d, EnumAttributeParser e)

Use a bit of code to tease apart the two halves, being careful to
tolerate:

NNNuuu
{}uuu
NNN{}
{}{}

and delegate the actual parsing. Really, I think you should go ahead and
do that.

http://gwt-code-reviews.appspot.com/103806

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to