Reviewers: jat, mmendez, Description: Drop Request/Response Logging Levels down to TRACE.
Please review this at http://gwt-code-reviews.appspot.com/103812 Affected files: M dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java Index: dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java diff --git a/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java b/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java index efffd12dc9005a3e0de0105df9d286cc1deba8e2..4231ae9a8c37a0a080ddb26e2821be10feb282ac 100644 --- a/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java +++ b/dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java @@ -72,10 +72,21 @@ public class JettyLauncher extends ServletContainerLauncher { logStatus = TreeLogger.ERROR; logHeaders = TreeLogger.INFO; } else if (status >= 400) { - logStatus = TreeLogger.WARN; - logHeaders = TreeLogger.INFO; + if (status == 404 && "/favicon.ico".equals(request.getRequestURI()) + && request.getQueryString() == null) { + /* + * This is an automatic request performed by most browsers. There is + * no reason to call the developer's attention to the fact that + * favicon.ico is not present. + */ + logStatus = TreeLogger.TRACE; + logHeaders = TreeLogger.DEBUG; + } else { + logStatus = TreeLogger.WARN; + logHeaders = TreeLogger.INFO; + } } else { - logStatus = TreeLogger.INFO; + logStatus = TreeLogger.TRACE; logHeaders = TreeLogger.DEBUG; } String userString = request.getRemoteUser(); @@ -235,7 +246,7 @@ public class JettyLauncher extends ServletContainerLauncher { try { server.stop(); server.setStopAtShutdown(false); - branch.log(TreeLogger.INFO, "Stopped successfully"); + branch.log(TreeLogger.TRACE, "Stopped successfully"); } catch (Exception e) { branch.log(TreeLogger.ERROR, "Unable to stop embedded Jetty server", e); throw new UnableToCompleteException(); @@ -405,8 +416,8 @@ public class JettyLauncher extends ServletContainerLauncher { private final TreeLogger logger; /** - * In the usual case of launching {...@link com.google.gwt.dev.DevMode}, - * this will always by the system app ClassLoader. + * In the usual case of launching {...@link com.google.gwt.dev.DevMode}, this + * will always by the system app ClassLoader. */ private final ClassLoader systemClassLoader = Thread.currentThread().getContextClassLoader(); -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
