Revision: 7009 Author: [email protected] Date: Wed Nov 18 15:02:16 2009 Log: Properly sorts the get/setCodeServerPort methods
Change by: bruce Review by: rjrjr (TBR) http://code.google.com/p/google-web-toolkit/source/detail?r=7009 Modified: /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java ======================================= --- /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Wed Nov 18 13:50:42 2009 +++ /trunk/dev/core/src/com/google/gwt/dev/DevModeBase.java Wed Nov 18 15:02:16 2009 @@ -148,6 +148,57 @@ return BrowserWidgetHostChecker.blacklistRegexes(blacklistStr); } } + + /** + * Handles the -portHosted command line flag. + */ + protected static class ArgHandlerCodeServerPort extends ArgHandlerString { + + private static final String CODE_SERVER_PORT_TAG = "-codeServerPort"; + private static final String DEFAULT_PORT = "9997"; + + private final OptionCodeServerPort options; + + public ArgHandlerCodeServerPort(OptionCodeServerPort options) { + this.options = options; + } + + @Override + public String[] getDefaultArgs() { + return new String[] {CODE_SERVER_PORT_TAG, DEFAULT_PORT}; + } + + @Override + public String getPurpose() { + return "Specifies the TCP port for the code server (defaults to " + + DEFAULT_PORT + ")"; + } + + @Override + public String getTag() { + return CODE_SERVER_PORT_TAG; + } + + @Override + public String[] getTagArgs() { + return new String[] {"port-number | \"auto\""}; + } + + @Override + public boolean setString(String value) { + if (value.equals("auto")) { + options.setCodeServerPort(getFreeSocketPort()); + } else { + try { + options.setCodeServerPort(Integer.parseInt(value)); + } catch (NumberFormatException e) { + System.err.println("A port must be an integer or \"auto\""); + return false; + } + } + return true; + } + } /** * Handles the -logdir command line option. @@ -254,57 +305,6 @@ return true; } } - - /** - * Handles the -portHosted command line flag. - */ - protected static class ArgHandlerCodeServerPort extends ArgHandlerString { - - private static final String CODE_SERVER_PORT_TAG = "-codeServerPort"; - private static final String DEFAULT_PORT = "9997"; - - private final OptionCodeServerPort options; - - public ArgHandlerCodeServerPort(OptionCodeServerPort options) { - this.options = options; - } - - @Override - public String[] getDefaultArgs() { - return new String[] {CODE_SERVER_PORT_TAG, DEFAULT_PORT}; - } - - @Override - public String getPurpose() { - return "Specifies the TCP port for the code server (defaults to " + - DEFAULT_PORT + ")"; - } - - @Override - public String getTag() { - return CODE_SERVER_PORT_TAG; - } - - @Override - public String[] getTagArgs() { - return new String[] {"port-number | \"auto\""}; - } - - @Override - public boolean setString(String value) { - if (value.equals("auto")) { - options.setCodeServerPort(getFreeSocketPort()); - } else { - try { - options.setCodeServerPort(Integer.parseInt(value)); - } catch (NumberFormatException e) { - System.err.println("A port must be an integer or \"auto\""); - return false; - } - } - return true; - } - } protected static class ArgHandlerRemoteUI extends ArgHandlerString { @@ -361,8 +361,6 @@ } } - protected static final Map<String, ModuleDef> startupModules = new HashMap<String, ModuleDef>(); - /** * Handles the -whitelist command line flag. */ @@ -387,7 +385,7 @@ return BrowserWidgetHostChecker.whitelistRegexes(whitelistStr); } } - + protected interface HostedModeBaseOptions extends JJSOptions, OptionLogDir, OptionLogLevel, OptionGenDir, OptionNoServer, OptionPort, OptionCodeServerPort, OptionStartupURLs, OptionRemoteUI { @@ -428,6 +426,10 @@ public String getClientId() { return remoteUIClientId; } + + public int getCodeServerPort() { + return portHosted; + } public File getLogDir() { return logDir; @@ -443,10 +445,6 @@ public int getPort() { return port; } - - public int getCodeServerPort() { - return portHosted; - } public String getRemoteUIHost() { return remoteUIHost; @@ -471,6 +469,10 @@ public void setClientId(String clientId) { this.remoteUIClientId = clientId; } + + public void setCodeServerPort(int port) { + portHosted = port; + } public void setLogFile(String filename) { logDir = new File(filename); @@ -483,10 +485,6 @@ public void setPort(int port) { this.port = port; } - - public void setCodeServerPort(int port) { - portHosted = port; - } public void setRemoteUIHost(String remoteUIHost) { this.remoteUIHost = remoteUIHost; @@ -500,6 +498,12 @@ return remoteUIHost != null; } } + + protected interface OptionCodeServerPort { + int getCodeServerPort(); + + void setCodeServerPort(int codeServerPort); + } /** * Controls whether and where to log data to file. @@ -534,12 +538,6 @@ void setPort(int port); } - - protected interface OptionCodeServerPort { - int getCodeServerPort(); - - void setCodeServerPort(int codeServerPort); - } /** * Controls the UI that should be used to display the dev mode server's data. @@ -584,6 +582,8 @@ registerHandler(new ArgHandlerRemoteUI(options)); } } + + protected static final Map<String, ModuleDef> startupModules = new HashMap<String, ModuleDef>(); private static final Random RNG = new Random(); -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
