Thanks. I ended up deleting the issue because Bruce committed a fix separately. Thanks for looking at it though.
On Thu, Nov 19, 2009 at 9:14 AM, Rajeev Dayal <[email protected]> wrote: > The Rietveld link does not seem to be working, but LGTM. > > > On Wed, Nov 18, 2009 at 5:18 PM, <[email protected]> wrote: > >> Reviewers: rdayal, jat, >> >> >> >> Please review this at http://gwt-code-reviews.appspot.com/103813 >> >> Affected files: >> M dev/core/src/com/google/gwt/dev/DevModeBase.java >> >> >> Index: dev/core/src/com/google/gwt/dev/DevModeBase.java >> diff --git a/dev/core/src/com/google/gwt/dev/DevModeBase.java >> b/dev/core/src/com/google/gwt/dev/DevModeBase.java >> index >> 511d5458f848e1493c608c267ba5840971ae98eb..4bb36ecc206b3a9d83999be4cb8bb2ad4a279d95 >> 100644 >> --- a/dev/core/src/com/google/gwt/dev/DevModeBase.java >> +++ b/dev/core/src/com/google/gwt/dev/DevModeBase.java >> @@ -429,6 +429,10 @@ abstract class DevModeBase implements DoneCallback { >> return remoteUIClientId; >> } >> >> + public int getCodeServerPort() { >> + return portHosted; >> + } >> + >> public File getLogDir() { >> return logDir; >> } >> @@ -444,10 +448,6 @@ abstract class DevModeBase implements DoneCallback { >> return port; >> } >> >> - public int getCodeServerPort() { >> - return portHosted; >> - } >> - >> public String getRemoteUIHost() { >> return remoteUIHost; >> } >> @@ -472,6 +472,10 @@ abstract class DevModeBase implements DoneCallback { >> this.remoteUIClientId = clientId; >> } >> >> + public void setCodeServerPort(int port) { >> + portHosted = port; >> + } >> + >> public void setLogFile(String filename) { >> logDir = new File(filename); >> } >> @@ -484,10 +488,6 @@ abstract class DevModeBase implements DoneCallback { >> this.port = port; >> } >> >> - public void setCodeServerPort(int port) { >> - portHosted = port; >> - } >> - >> public void setRemoteUIHost(String remoteUIHost) { >> this.remoteUIHost = remoteUIHost; >> } >> @@ -502,6 +502,15 @@ abstract class DevModeBase implements DoneCallback { >> } >> >> /** >> + * Controls what code server port to use. >> + */ >> + protected interface OptionCodeServerPort { >> + int getCodeServerPort(); >> + >> + void setCodeServerPort(int codeServerPort); >> + } >> + >> + /** >> * Controls whether and where to log data to file. >> * >> */ >> @@ -535,12 +544,6 @@ abstract class DevModeBase implements DoneCallback { >> void setPort(int port); >> } >> >> - protected interface OptionCodeServerPort { >> - int getCodeServerPort(); >> - >> - void setCodeServerPort(int codeServerPort); >> - } >> - >> /** >> * Controls the UI that should be used to display the dev mode server's >> data. >> */ >> >> >> > -- Miguel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
